Skip to content

docs: Roll out DR-002-Proc FEP process across contributor docs#3076

Merged
masc2023 merged 1 commit into
mainfrom
qor-lb_fep_rollout
Jul 21, 2026
Merged

docs: Roll out DR-002-Proc FEP process across contributor docs#3076
masc2023 merged 1 commit into
mainfrom
qor-lb_fep_rollout

Conversation

@qor-lb

@qor-lb qor-lb commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Implements the consequences of DR-002-Proc (accepted), which introducesthe Feature & Enhancement Proposal (FEP) process for Feature and major Feature Modification change requests.

Changes:

  • feature_request.rst rewritten as the living FEP Process Guide, superseding the old TL-circle review guideline: roles, labels, the five process phases with tracking-issue lifecycle, and the FEP template.
  • change_management.rst: FEP routing added for Feature and major Feature Modification CRs.
  • software_architecture_overview.rst: references updated to the FEP Process Guide.
  • project_management.rst: Feature Request definition aligned with the FEP tracking issue (type Feature Request, may parent child Task issues for implementation tracking).

See DR-002-Proc for the decision and rationale.

Refs #3061

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

Comment thread docs/contribute/contribution_request/feature_request.rst Outdated
Comment thread docs/contribute/contribution_request/feature_request.rst Outdated

A proposal classified as **Breaking Change** must additionally include:

* **Impact Inventory**: explicit list of known integrators, configurations, or customer deliverables that will break

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right that the Breaking Change section doesnt clearly relate to FR template today, but I think the actual problem might be one level up.

The FR template currently serves two different purposes in one file: proposing a change (Motivation, Backwards Compatibility, Rejected Ideas, Open Issues - point-in-time, argument-for-the-change content) and documenting the resulting feature (Abstract, Rationale, Specification, Security/Safety Impact - living, current-state content).

My intent here (not yet fully reflected/settled): separate these explicitly. A Feature Change / FEP record carries the proposal-only content, including Backwards Compatibility, and lives with the change. Feature Documentation stays in docs/features/ with only Abstract, Rationale, Specification, Security Impact, Safety Impact, kept current as the feature evolves. Some headings would appear in both but ask a different question - e.g. Safety Impact of the feature overall vs. Safety Impact of this specific change - so one wouldnt simply reference the other.

This might be bigger than this PR since it touches FT template, used by every existing feature doc. Genuinely open on this - I would like your/the Process Communities read before committing.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masc2023 is this resolved or do you still see actions open to be incorporated to resolve the comment?

Comment thread docs/platform_management_plan/project_management.rst Outdated
@qor-lb
qor-lb force-pushed the qor-lb_fep_rollout branch 2 times, most recently from e8953f9 to 1c044ce Compare July 12, 2026 16:15
@qor-lb
qor-lb requested a review from arsibo July 12, 2026 16:17
Comment thread docs/contribute/contribution_request/feature_request.rst Outdated
FScholPer
FScholPer previously approved these changes Jul 13, 2026

@aschemmel-tech aschemmel-tech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a hard time to understand this, need to re-review at a later time

Comment thread docs/contribute/contribution_request/feature_request.rst Outdated
Comment thread docs/platform_management_plan/change_management.rst Outdated

@aschemmel-tech aschemmel-tech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now I re-reviewed all

Comment thread docs/platform_management_plan/change_management.rst Outdated
Comment thread docs/platform_management_plan/change_management.rst Outdated
Comment thread docs/platform_management_plan/change_management.rst Outdated
Comment thread docs/platform_management_plan/change_management.rst Outdated
Comment thread docs/contribute/contribution_request/feature_request.rst Outdated
Comment thread docs/contribute/contribution_request/feature_request.rst Outdated
Comment thread docs/contribute/contribution_request/feature_request.rst Outdated
Feature requests are at the heart of our evolution. They describe the intended functionality of the S-CORE platform and serve as a collaborative starting point where maintainers and contributors align on new ideas. These requests not only define the motivation and requirements but also shape the technical roadmap for future developments. We invite you to check out all current feature requests on our
`Feature Request Board <https://github.com/orgs/eclipse-score/projects/4>`_.

New Feature and major Feature Modification requests go through the :need:`FEP process <doc__feature_request_guideline>`, where an Architecture Community Shepherd guides the proposal to a Final Comment Period before it's decided. Component-level and single-Feature-Team changes are handled directly by the responsible team, as described in the :need:`doc__platform_change_management_plan`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As FEP process is part of Change Management Process, I would propose to call it FEP workflow, procedure, way or working, rather then process, compare PEP, intend is to describe new features/etc. for S-CORE or simply.
In the PMP you call it now Track...

...go through a Feature Enhancement Proposal (FEP), where an .....

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorporated


Feature Request Guideline
##############################
Feature & Enhancement Proposal (FEP) Process

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove process, see also other comments

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread docs/platform_management_plan/change_management.rst
Some changes carry enough governance weight that the decision is worth persisting, and the
community needs a structured way to reach agreement before implementation starts, rather than
relying on a single Committer's review. For these, **Analyze** is specialized into the **FEP
process**: a Shepherd sponsors the proposal, a time-boxed Final Comment Period

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove process in every place

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Comment thread docs/platform_management_plan/change_management.rst
They are in the responsibility of the :ref:`Architecture Community <pmp_pm_arc>`, shall aligned with :ref:`Project / Technical Lead Circle <pmp_pm_plctlc>` and the issues are part of the :ref:`Root Repository <pmp_pm_root_repository>`.
other work packages, including as a parent to child Task issues used for implementation tracking once a FEP is accepted. *Feature Request* covers new Features as well as significant modifications of existing Features.

Feature Requests are governed by the FEP process (see the :ref:`FEP Process Guide <feature_request_guideline>`): the :ref:`Architecture Community <pmp_pm_arc>` owns the review via a Shepherd and Final Comment Period. The :ref:`Project / Technical Lead Circle <pmp_pm_plctlc>` triages incoming requests and is notified once a FEP enters its Final Comment Period, for roadmap awareness. Feature Requests are part of the :ref:`Root Repository <pmp_pm_root_repository>`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove process everywhre

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

**responsible for maintaining and evolving the architecture**.

By creating a **feature request**, structural changes as well as new functionality can be **proposed at any time**.
Structural changes and new functionality are proposed through the **FEP process**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove process everywhere

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Comment thread docs/contribute/contribution_request/feature_request.rst
Implement the consequences of DR-002-Proc (FEP process) across the
four affected documents:
- feature_request.rst: rewritten as the living FEP Process Guide,
  superseding the old TL-circle review guideline. Defines roles
  (Author, Shepherd, Architecture Community), labels, the five
  process phases with tracking-issue lifecycle, and the FEP
  template.
- change_management.rst: adds FEP routing for Feature and major
  Feature Modification CRs.
- software_architecture_overview.rst: updates references from the
  old guideline to the FEP Process Guide.
- project_management.rst: aligns the Feature Request definition
  with the FEP tracking issue (type Feature Request, allowed as a
  parent to child Task issues for implementation tracking).

Assisted-by: Claude:claude-sonnet-5
@qor-lb
qor-lb force-pushed the qor-lb_fep_rollout branch from 46c1f5a to 953bab3 Compare July 20, 2026 11:07
@qor-lb
qor-lb requested a review from masc2023 July 20, 2026 11:10

@masc2023 masc2023 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my comments are resolved now

@FScholPer

Copy link
Copy Markdown
Contributor

@aschemmel-tech can you check again?

@aschemmel-tech aschemmel-tech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my comments resolved

@masc2023
masc2023 merged commit f13d454 into main Jul 21, 2026
7 checks passed
@masc2023
masc2023 deleted the qor-lb_fep_rollout branch July 21, 2026 10:09
@github-project-automation github-project-automation Bot moved this from Backlog to Done in S-CORE Roadmap Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants